Add declarative import for direct deployment engine#4630
Draft
shreyas-goenka wants to merge 5 commits intomainfrom
Draft
Add declarative import for direct deployment engine#4630shreyas-goenka wants to merge 5 commits intomainfrom
shreyas-goenka wants to merge 5 commits intomainfrom
Conversation
Allow users to import existing workspace resources into bundle management at deploy time using import blocks in target configuration. This is analogous to Terraform's import blocks and enables taking over management of resources without recreating them. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shreyas-goenka
requested review from
andrewnester,
anton-107,
denik and
pietern
as code owners
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 47d4e3e
32 interesting tests: 11 FAIL, 7 KNOWN, 7 SKIP, 5 BUG, 1 RECOVERED, 1 flaky
Top 20 slowest tests (at least 2 minutes):
|
Add validations for: - Import blocks used with terraform engine (must use direct engine) - Import blocks referencing undefined resources (orphaned imports) Add acceptance tests for: - Recreate blocked for imported resources (changing immutable field) - Orphaned import blocks (import references non-existent resource) - Import blocks rejected with terraform engine Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Rename the "import" configuration block to "bind" throughout the codebase to better reflect the semantics of binding existing workspace resources into bundle management. Also refactor the Bind type from a hardcoded struct with 21 resource type fields to a dynamic map[string]map[string]BindResource, reducing the implementation from ~225 lines to ~42 lines and eliminating the need to update the type when new resource types are added. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
importblocks to target configuration, allowing users to import existing workspace resources (jobs, pipelines, etc.) into bundle management at deploy timeimport(no config changes) andimport_and_update(import + apply changes)bundle deployment migratewhen import blocks are defined, since they are only supported with the direct engineTest plan
acceptance/bundle/deploy/import/basic)acceptance/bundle/deploy/import/import-and-update)acceptance/bundle/deploy/import/block-migrate)acceptance/bundle/deploy/import/resource-not-found)🤖 Generated with Claude Code