chore: replace unmaintained paste crate with pastey#3238
chore: replace unmaintained paste crate with pastey#3238thepastaclaw wants to merge 1 commit intodashpay:v3.1-devfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughReplaced the unmaintained Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PastaPastaPasta
left a comment
There was a problem hiding this comment.
ACK; I've reviewed pastey, has stars, seems legit. It exists, and is a maintained fork of unmaintained paste. pastey is a drop in replacement, according to their docs.
833dc98 to
c935a9b
Compare
Resolves dashpay#2487 (RUSTSEC-2024-0436) pastey is an API-compatible maintained fork of paste. The only direct usage was in packages/wasm-dpp (Cargo.toml dependency + one import in generic_consensus_error.rs).
c935a9b to
8a2a015
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.1-dev #3238 +/- ##
============================================
- Coverage 55.87% 0 -55.88%
============================================
Files 3173 0 -3173
Lines 235215 0 -235215
============================================
- Hits 131435 0 -131435
+ Misses 103780 0 -103780
🚀 New features to boost your workflow:
|
Resolves #2487 (RUSTSEC-2024-0436)
What
Replaces the unmaintained
pastecrate withpastey, its API-compatible maintained fork.Changes
packages/wasm-dpp/Cargo.toml:paste = "1.0.14"→pastey = "0.2.1"packages/wasm-dpp/src/errors/generic_consensus_error.rs:paste::paste→pastey::pasteThat's it — two lines.
pasteyis a drop-in replacement.Validation
cargo check -p wasm-dpp✅Summary by CodeRabbit