CM-61550: Show upload progress and detect slow connections during scan#419
Open
mateusz-sterczewski wants to merge 2 commits intomainfrom
Open
CM-61550: Show upload progress and detect slow connections during scan#419mateusz-sterczewski wants to merge 2 commits intomainfrom
mateusz-sterczewski wants to merge 2 commits intomainfrom
Conversation
Collaborator
mateusz-sterczewski
commented
Mar 26, 2026
mateusz-sterczewski
commented
- Add _UploadProgressTracker to CycodeClientBase: a file-like wrapper that tracks bytes sent and fires a progress callback on each read
- Add post_multipart() to CycodeClientBase with retry via @Retry decorator; detects mid-transfer connection drops and raises SlowUploadConnectionError for partial uploads
- Add _UploadProgressAggregator to code_scanner: aggregates progress across parallel batch uploads and displays MB sent / MB total in the progress bar right-side label
- Add SlowUploadConnectionError with a user-friendly CLI error message
- Thread on_upload_progress callback through _perform_scan, _perform_scan_async, and _perform_scan_v4_async
- Add test coverage for slow upload detection
- Add _UploadProgressTracker to CycodeClientBase: a file-like wrapper that tracks bytes sent and fires a progress callback on each read - Add post_multipart() to CycodeClientBase with retry via @Retry decorator; detects mid-transfer connection drops and raises SlowUploadConnectionError for partial uploads - Add _UploadProgressAggregator to code_scanner: aggregates progress across parallel batch uploads and displays MB sent / MB total in the progress bar right-side label - Add SlowUploadConnectionError with a user-friendly CLI error message - Thread on_upload_progress callback through _perform_scan, _perform_scan_async, and _perform_scan_v4_async - Add test coverage for slow upload detection Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![cycode-security[bot]](https://avatars.githubusercontent.com/in/39308?s=60&v=4){kind=small}
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
gotbadger
reviewed
Mar 26, 2026
| from cycode.cli.files_collector.models.in_memory_zip import InMemoryZip | ||
| from cycode.cyclient import models | ||
| from cycode.cyclient.cycode_client_base import CycodeClientBase | ||
| from cycode.cyclient.cycode_client_base import CycodeClientBase, _UploadProgressTracker |
Collaborator
There was a problem hiding this comment.
importing _ named class here ie private
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.