Open
Conversation
Vegetable26
commented
Mar 23, 2026
| find_package(OpenMP REQUIRED) | ||
|
|
||
| # Apple Clang does not bundle OpenMP; point FindOpenMP at Homebrew's libomp. | ||
| if(APPLE) |
Author
There was a problem hiding this comment.
nit: mainly for my own setup
Vegetable26
commented
Mar 23, 2026
| FetchContent_MakeAvailable(xnnpack) | ||
| set(XNNPACK_LINK_LIBRARIES XNNPACK pthreadpool) | ||
|
|
||
| add_compile_definitions(CMAKE_SOURCE_DIR="${CMAKE_SOURCE_DIR}" BENCHMARK_TIME) |
Author
There was a problem hiding this comment.
nit: mainly for my own setup
Vegetable26
commented
Mar 23, 2026
examples/simple_clustering.cpp
Outdated
| @@ -1,17 +1,20 @@ | |||
| #define BENCHMARK_TIME | |||
Author
There was a problem hiding this comment.
nit: most of the changes here are for my own setup (quickly running a few different experiments)
added 3 commits
March 22, 2026 23:18
477c167 to
f00dd07
Compare
added 2 commits
March 22, 2026 23:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to the core algorithm:
I attached the experimental results for a cohere 2M benchmark (my Mac does not have enough memory for the full benchmark). Some interesting results: