Handle failures in BeforeAll hooks and AfterAll hooks#1857
Open
brasmusson wants to merge 1 commit intomainfrom
Open
Handle failures in BeforeAll hooks and AfterAll hooks#1857brasmusson wants to merge 1 commit intomainfrom
brasmusson wants to merge 1 commit intomainfrom
Conversation
* All BeforeAll hooks and AfterAll hooks shall be executed regardless of they pass or fail. * The TestCases shall only be executed if all BeforeAll hooks passes. * BeforeAll hooks shall be executed after the TestRunStarted event has fired. * AfterAll hooks shall be executed before the TestRunFinished event is fired. * Print the global hook failures shall be printed by the console formatters. * Aslo global hook failures shall affect the exit code.
luke-hill
reviewed
Apr 13, 2026
Contributor
luke-hill
left a comment
luke-hill
left a comment
There was a problem hiding this comment.
Once v11 is out I'll get to this. Might take me a week or two
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With this change Cucumber-Ruby conforms fully with CCK v22
Type of change
Please delete options that are not relevant.
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.
bundle exec rubocopreports no offenses