Skip to content

adding intent filters for Navi#113

Open
AbigailLabanok wants to merge 2 commits intomainfrom
abby/navi-intents
Open

adding intent filters for Navi#113
AbigailLabanok wants to merge 2 commits intomainfrom
abby/navi-intents

Conversation

@AbigailLabanok
Copy link
Copy Markdown

@AbigailLabanok AbigailLabanok commented Apr 22, 2026

Overview

Added the necessary intent filters for Navi.

Changes Made

New Intent Filters:

  • action.VIEW
  • category.DEFAULT
  • category.BROWSABLE

Summary by CodeRabbit

  • New Features
    • Added support for deep linking via the "uplift" URI scheme. Users can open uplift:// links to navigate directly to app content; these links are recognized by the system and can be opened from browsers or other apps.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5e9700ab-adb3-414c-9d05-608447215fc7

📥 Commits

Reviewing files that changed from the base of the PR and between 6312e9a and 558353a.

📒 Files selected for processing (1)
  • app/src/main/AndroidManifest.xml
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/src/main/AndroidManifest.xml

📝 Walkthrough

Walkthrough

MainActivity's manifest now includes a new android.intent.action.VIEW intent-filter with DEFAULT and BROWSABLE categories, scoped to the uplift URI scheme to enable deep-link invocation into the app.

Changes

Cohort / File(s) Summary
Deep Link Configuration
app/src/main/AndroidManifest.xml
Added an intent-filter to MainActivity to handle android.intent.action.VIEW deep links using the uplift URI scheme with DEFAULT and BROWSABLE categories.

Sequence Diagram(s)

sequenceDiagram
    participant Browser as Browser
    participant OS as Android OS (Intent Resolver)
    participant App as App (MainActivity)

    Browser->>OS: User taps uplift://... link
    OS-->>Browser: Resolve intent for `uplift` scheme
    OS->>App: Launch intent (ACTION_VIEW, categories: DEFAULT,BROWSABLE)
    App-->>OS: onCreate / onNewIntent handles deep link
    App->>App: Parse URI and navigate to target screen
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

I sniff the uplift scheme today,
A tiny hop, a linking way,
From browser burrow to app so near,
I bound across intent frontier,
🐇✨ Deep-link carrots drawing cheer.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description includes Overview and Changes Made sections but is missing critical sections like Test Coverage and lacks detailed explanation of how the changes work. Add Test Coverage section describing how the intent filters were tested, and provide more details about the uplift URI scheme and how the changes enable Navi integration.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'adding intent filters for Navi' directly summarizes the main change in the pull request, which adds intent filters to support Navi functionality.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch abby/navi-intents

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@app/src/main/AndroidManifest.xml`:
- Around line 27-37: The current single <intent-filter> mixes launcher actions
(android.intent.action.MAIN + android.intent.category.LAUNCHER) with a data
scheme constraint (android:scheme="uplift"), preventing .MainActivity from being
resolved as the app launcher; split this into two intent-filter entries: one
intent-filter containing only android.intent.action.MAIN and
android.intent.category.LAUNCHER (no <data> element or VIEW/DEFAULT/BROWSABLE
categories) and a separate intent-filter for deep links containing
android.intent.action.VIEW plus android.intent.category.DEFAULT and
android.intent.category.BROWSABLE and the <data android:scheme="uplift" />
element so the launcher and deep-link behaviors work independently.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 410be488-2063-43e8-946f-9a3f6c8f43ad

📥 Commits

Reviewing files that changed from the base of the PR and between 338cee3 and 6312e9a.

📒 Files selected for processing (1)
  • app/src/main/AndroidManifest.xml

Comment thread app/src/main/AndroidManifest.xml
Copy link
Copy Markdown
Member

@AndrewCheung360 AndrewCheung360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but double check the coderabbit comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants