-
Notifications
You must be signed in to change notification settings - Fork 0
Initial Highlights Networking #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amjiao
wants to merge
16
commits into
main
Choose a base branch
from
amy-highlights-networking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
3c52ba2
small nav fix
amjiao e719842
Merge branch 'main' into amy-highlights-networking
amjiao e02cc5d
UI Fixes
amjiao 7832187
graphql files
amjiao b439f22
highlights models
amjiao 95a4f88
added ISO date parsing function
amjiao a67099b
refactor sports type
amjiao 90a2599
highlights viewmodel
amjiao bb2ed84
Style fixes
amjiao 5d1fb1d
Add dateString field to HighlightsData type
amjiao a6c076a
Refactor HighlightsViewModel
amjiao 935046a
Fix refresh logic bug
amjiao a8e2caa
Fix documentation discrepancies
amjiao de8f4cd
Address coderabbit comments
amjiao fd54480
Merge highlights networking branches (#108)
amjiao 259e6d1
add missing val
amjiao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| query Highlights($sportsType: String) { | ||
| articles(sportsType: $sportsType) { | ||
| title | ||
| image | ||
| sportsType | ||
| publishedAt | ||
| url | ||
| } | ||
| youtubeVideos { | ||
| title | ||
| thumbnail | ||
| url | ||
| publishedAt | ||
| duration | ||
| sportsType | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preview click no longer toggles
isSelected.The lambda passed to
onFilterSelectednow has signature(SportSelection) -> Unit.{ !isSelected }just computes and discards!isSelected; the preview button won't actually toggle its selected state on click. Wire the state update through the callback so the preview reflects real behavior.🛠️ Proposed fix
🤖 Prompt for AI Agents