feat: Implement rustls APIs for QUIC in rustls-graviola#156
Draft
feat: Implement rustls APIs for QUIC in rustls-graviola#156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This takes the
jbp-quicbranch and adapts it tonoq(and rebased it onmain).The only reason for switching to
noqis that it supports depending on it with therustlsfeature flag without bringing in neitherringnoraws-lc-rs.Other than that this also implements
rustls::quic::PacketKey::{encrypt,decrypt}_in_place_for_pathso it supports multipath (I originally did this work to test out using graviola as the crypto provider for iroh).This is still a draft, as it probably deserves another round of cleanups.
quic-clientandquic-serverduplicate a bit of code (theHmacKeyimplementation mostly).From looking through the code it seems like these are the remaining TODOs: