Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a new Style Guides API module to the Java client, including models, API methods, and mock-based tests/resources.
Changes:
- Introduces
StyleGuidesApiwith CRUD + list operations for/style-guides. - Adds
StyleGuidedomain model plus request/response wrapper models and list query params. - Wires the new API into the root
Clientand adds tests + JSON fixtures.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/main/java/com/crowdin/client/styleguide/StyleGuidesApi.java |
Implements Style Guides endpoints (list/add/get/edit/delete). |
src/main/java/com/crowdin/client/styleguide/model/StyleGuide.java |
Adds Style Guide entity model. |
src/main/java/com/crowdin/client/styleguide/model/AddStyleGuideRequest.java |
Adds request model for creating style guides. |
src/main/java/com/crowdin/client/styleguide/model/ListStyleGuidesParams.java |
Adds list query params (pagination + order/user filters). |
src/main/java/com/crowdin/client/styleguide/model/StyleGuideResponseObject.java |
Adds response wrapper for single style guide. |
src/main/java/com/crowdin/client/styleguide/model/StyleGuideResponseList.java |
Adds response wrapper + conversion for list responses. |
src/main/java/com/crowdin/client/Client.java |
Exposes StyleGuidesApi from the root client. |
src/test/java/com/crowdin/client/styleguide/StyleGuidesApiTest.java |
Adds mock-based unit tests for the new API. |
src/test/resources/api/styleguide/styleGuide.json |
Adds mocked single-item API response fixture. |
src/test/resources/api/styleguide/listStyleGuides.json |
Adds mocked list API response fixture. |
src/test/resources/api/styleguide/addStyleGuideRequest.json |
Adds mocked create request fixture. |
src/test/resources/api/styleguide/editStyleGuide.json |
Adds mocked patch request fixture. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
src/main/java/com/crowdin/client/styleguide/StyleGuidesApi.java
Outdated
Show resolved
Hide resolved
src/main/java/com/crowdin/client/styleguide/StyleGuidesApi.java
Outdated
Show resolved
Hide resolved
Author
|
Fixed all copilot issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.