Fix hang on UTF-16 LE BOM file

[chrchr-github]

fixes #637

[firewave]

Yeah - there's several places which lack checks for EOF. I have WIP tests for that and other corner cases/gaps somewhere - something to be done in preparation of #566.

[firewave]

With #647 it should be possible to write a test which uses the input in question.

[chrchr-github]

With #647 it should be possible to write a test which uses the input in question.

Can we just run the tests with all three options?

[firewave]

Can we just run the tests with all three options?

Yes, if somebody adds the functionality. It didn't seem straight forward to me so I haven't yet. Feel free to do so.

[firewave]

I think I took a wrong turn. That should trigger with regular unit test. So please add a test for it.

[firewave]

I think I took a wrong turn. That should trigger with regular unit test. So please add a test for it.

Ah - you mentioned FileStream in the ticket. Still I think we should have a unit test (if missing).