Skip to content

chore(dev): update release-drafter usage#410

Merged
2bndy5 merged 1 commit intomainfrom
release-drafter-update
Mar 17, 2026
Merged

chore(dev): update release-drafter usage#410
2bndy5 merged 1 commit intomainfrom
release-drafter-update

Conversation

@2bndy5
Copy link
Collaborator

@2bndy5 2bndy5 commented Mar 17, 2026

  • remove unused release-drafter config
  • update permissions for jobs that invoke reusable release-drafter workflows
  • switch labeler workflow to use separate reusable workflow

refs:

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflow configurations to refine permissions management and access controls for automated processes. These infrastructure adjustments streamline release and labeling workflow operations.

- [x] remove unused config
- [x] update permissions for jobs that invoke reusable release-drafter workflows
- [x] switch labeler workflow to use separate reusable workflow

refs:
- cpp-linter/.github#71
- cpp-linter/.github#74
@2bndy5 2bndy5 requested a review from a team as a code owner March 17, 2026 10:21
@2bndy5 2bndy5 requested review from shenxianpeng and removed request for a team March 17, 2026 10:21
@2bndy5 2bndy5 added the github_actions Pull requests that update GitHub Actions code label Mar 17, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 17, 2026

Walkthrough

This pull request modifies GitHub workflow configuration files to update permissions management. The release-drafter configuration removes inherited settings, while workflow files add explicit permissions blocks to control repository access during workflow execution.

Changes

Cohort / File(s) Summary
Release Drafter Configuration
.github/release-drafter.yml
Removes inheritance from .github, eliminating global/default settings and applying only explicitly defined settings within this file.
Workflow Permissions Management
.github/workflows/labeler.yml, .github/workflows/release-drafter.yml
Adds top-level and job-level permissions blocks to explicitly define repository access control. Updates labeler workflow action reference and grants contents read/write and pull-requests permissions as needed for workflow execution.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

developer

Suggested reviewers

  • shenxianpeng
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore(dev): update release-drafter usage' accurately describes the main changes: updating release-drafter configuration and permissions across workflow files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release-drafter-update
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can customize the tone of the review comments and chat replies.

Configure the tone_instructions setting to customize the tone of the review comments and chat replies. For example, you can set the tone to Act like a strict teacher, Act like a pirate and more.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/labeler.yml (1)

15-15: Consider pinning reusable workflow to a commit SHA instead of @main.

Using a mutable ref can introduce unreviewed behavior changes; pinning improves reproducibility and supply-chain safety. Note that this pattern is used across multiple workflows in the repository (stale.yml, release-drafter.yml, mkdocs-deploy.yml, pre-commit.yml, and others).

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/labeler.yml at line 15, Replace the mutable ref on the
reusable workflow import in the uses statement (the line currently `uses:
cpp-linter/.github/.github/workflows/pr-labeler.yml@main`) with a pinned commit
SHA; locate the uses entry in .github/workflows/labeler.yml (and mirror this
change in other workflows like stale.yml, release-drafter.yml,
mkdocs-deploy.yml, pre-commit.yml) and update `@main` to the specific commit SHA
of the referenced repo/tag so the workflow is immutable and reproducible.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/labeler.yml:
- Line 15: Replace the mutable ref on the reusable workflow import in the uses
statement (the line currently `uses:
cpp-linter/.github/.github/workflows/pr-labeler.yml@main`) with a pinned commit
SHA; locate the uses entry in .github/workflows/labeler.yml (and mirror this
change in other workflows like stale.yml, release-drafter.yml,
mkdocs-deploy.yml, pre-commit.yml) and update `@main` to the specific commit SHA
of the referenced repo/tag so the workflow is immutable and reproducible.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: add34395-c7f8-405b-89c6-b945909b02af

📥 Commits

Reviewing files that changed from the base of the PR and between 794df87 and 9fc8f3c.

📒 Files selected for processing (3)
  • .github/release-drafter.yml
  • .github/workflows/labeler.yml
  • .github/workflows/release-drafter.yml
💤 Files with no reviewable changes (1)
  • .github/release-drafter.yml

Copy link
Member

@shenxianpeng shenxianpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@2bndy5 2bndy5 merged commit 4f0870f into main Mar 17, 2026
8 of 9 checks passed
@2bndy5 2bndy5 deleted the release-drafter-update branch March 17, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants