Nt 2574 create react web sdk personalization component#167
Merged
Lotfi Anwar L Arif (Lotfi-Arif) merged 12 commits intomainfrom Mar 6, 2026
Merged
Conversation
- Split the React Web SDK dev app into modular sections for controls, state inspection, entry loading, and personalization. - Add hooks, constants, and utility functions to support entry fetching and state management. - Update styles for improved dashboard layout.
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Lotfi Anwar L Arif (Lotfi-Arif)
requested review from
Alex Freas (akfreas) and
Charles Hudson (phobetron)
as code owners
Comment on lines
+47
to
+50
| /** | ||
| * Optional legacy test id prop. | ||
| */ | ||
| testID?: string |
Collaborator
There was a problem hiding this comment.
This may not actually be necessary... aside from respecting old profile IDs in the local storage, the new SDK doesn't need to handle much legacy stuff.
packages/web/frameworks/react-web-sdk/src/personalization/Personalization.tsx
Outdated
Show resolved
Hide resolved
packages/web/frameworks/react-web-sdk/src/personalization/Personalization.tsx
Outdated
Show resolved
Hide resolved
packages/web/frameworks/react-web-sdk/src/personalization/Personalization.tsx
Show resolved
Hide resolved
Charles Hudson (phobetron)
previously approved these changes
Mar 6, 2026
Comment on lines
+36
to
+39
| /** | ||
| * Optional style prop for the wrapper element. | ||
| */ | ||
| style?: CSSProperties |
Collaborator
There was a problem hiding this comment.
We'll actually need to remove this I think.
Charles Hudson (phobetron)
approved these changes
Mar 6, 2026
Lotfi Anwar L Arif (Lotfi-Arif)
deleted the
NT-2574-create-react-web-sdk-personalization-component
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Personalizationparity in React Web with RN-matching resolution semantics.loadingFallback?: ReactNode | (({ baselineEntry }) => ReactNode).loadingFallbackis not provided.undefinedliveUpdatesoverrides root/global; default falsedata-ctfl-entry-iddata-ctfl-personalization-iddata-ctfl-stickydata-ctfl-variant-indexdata-ctfl-duplication-scope(currently supported)<Personalization />composition behavior.Personalization,PersonalizationProps, and loading-related public types from package entrypoint.