build: Bump github.com/spf13/cobra to 1.6.1#1776
build: Bump github.com/spf13/cobra to 1.6.1#1776debarshiray merged 7 commits intocontainers:mainfrom
Conversation
The src/go.sum file was updated with 'go mod tidy'. containers#1776
debarshiray
force-pushed
the
wip/rishi/github.com-spf13-cobra-1.5.0
branch
from
b713e91 to
5a559f5
Compare
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs routine dependency maintenance for the Go project. It updates a core command-line interface library to its next minor version and ensures the module's cryptographic checksums are accurate and minimal by tidying the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the github.com/spf13/cobra dependency from version v1.3.0 to v1.4.0 in src/go.mod, with corresponding changes in src/go.sum. A review comment notes a discrepancy between the pull request title, which suggests an update to v1.5.0, and the actual change to v1.4.0, requesting clarification or correction.
|
Build succeeded. ✔️ unit-test SUCCESS in 2m 10s |
The src/go.sum file was updated with 'go mod tidy'. containers#1776
|
Build succeeded. ✔️ unit-test SUCCESS in 2m 13s |
The cobra.FixedCompletions() convenience function was introduced in Cobra 1.5.0 [1] and commit df31b2f already added a dependency on it. Therefore, it should be exploited to simplify things by removing the need for a separate function. [1] https://pkg.go.dev/github.com/spf13/cobra#FixedCompletions containers#1776
|
Build succeeded. ✔️ unit-test SUCCESS in 2m 12s |
The indirect dependencies in the src/go.mod file, and the src/go.sum file were updated with 'go mod tidy'. containers#1776
This includes the --help and --version options in the generated shell
completions [1].
The indirect dependencies in the src/go.mod file, and the src/go.sum
file were updated with 'go mod tidy'.
[1] Cobra commit 212ea4078323771d
spf13/cobra@212ea4078323771d
spf13/cobra#1813
spf13/cobra#1786
containers#1776
debarshiray
force-pushed
the
wip/rishi/github.com-spf13-cobra-1.5.0
branch
from
a92dc4d to
00f47b2
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 2m 06s |
The cobra.ExactValidArgs() API [1] was deprecated in Cobra 1.6.0 [2] in favour of combining different cobra.PositionalArgs. Commit 00f47b2 already bumped the required github.com/spf13/cobra version to 1.6.0, so adjust accordingly. [1] https://pkg.go.dev/github.com/spf13/cobra#ExactValidArgs [2] Cobra commit 70e53f62be77e03f spf13/cobra@70e53f62be77e03f spf13/cobra#1643 spf13/cobra#745 spf13/cobra#838 containers#1776
|
Build succeeded. ✔️ unit-test SUCCESS in 2m 06s |
... in addition to the existing tests for one invalid or valid argument. This is meant to further ensure that the 'completion' command takes exactly one positional argument from the ones listed in cobra.Command.ValidArgs, and as specified by cobra.ExactValidArgs(1). containers#1776
The src/go.sum file was updated with 'go mod tidy'. containers#1776
The src/go.sum file was updated with 'go mod tidy'. containers#1776
debarshiray
force-pushed
the
wip/rishi/github.com-spf13-cobra-1.5.0
branch
from
4b72892 to
d62377a
Compare
The cobra.FixedCompletions() convenience function was introduced in Cobra 1.5.0 [1] and commit 4b02bf5 already added a dependency on it. Therefore, it should be exploited to simplify things by removing the need for a separate function. [1] https://pkg.go.dev/github.com/spf13/cobra#FixedCompletions containers#1776
This includes the --help and --version options in the generated shell
completions [1].
The indirect dependencies in the src/go.mod file, and the src/go.sum
file were updated with 'go mod tidy'.
[1] Cobra commit 212ea4078323771d
spf13/cobra@212ea4078323771d
spf13/cobra#1813
spf13/cobra#1786
containers#1776
The cobra.ExactValidArgs() API [1] was deprecated in Cobra 1.6.0 [2] in favour of combining different cobra.PositionalArgs. Commit 8b855c6 already bumped the required github.com/spf13/cobra version to 1.6.0, so adjust accordingly. [1] https://pkg.go.dev/github.com/spf13/cobra#ExactValidArgs [2] Cobra commit 70e53f62be77e03f spf13/cobra@70e53f62be77e03f spf13/cobra#1643 spf13/cobra#745 spf13/cobra#838 containers#1776
The src/go.sum file was updated with 'go mod tidy'. containers#1776
debarshiray
changed the title
|
Build succeeded. ✔️ unit-test SUCCESS in 2m 06s |
|
Build succeeded. ✔️ unit-test SUCCESS in 2m 09s |
|
Build succeeded. ✔️ unit-test SUCCESS in 2m 14s |
|
Build succeeded. ✔️ unit-test SUCCESS in 2m 18s |
|
Build succeeded. ✔️ unit-test SUCCESS in 2m 08s |
|
Build succeeded. ✔️ unit-test SUCCESS in 2m 08s |
1 participant
The
src/go.sumfile was updated withgo mod tidy.