init: don't fail if a fs is already mounted#647
Merged
slp merged 1 commit intocontainers:mainfrom Apr 24, 2026
Merged
Conversation
slp
requested review from
MatiasVara,
dorindabassey,
jakecorrenti,
mtjhrc and
tylerfanelli
as code owners
mtjhrc
reviewed
Apr 24, 2026
This allows us to use init.krun while booting from an initramfs. Signed-off-by: Sergio Lopez <slp@redhat.com>
slp
force-pushed
the
init-allow-reuse-fs
branch
from
45fe1b9 to
74aa373
Compare
Collaborator
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the mount_filesystems function in init/init.c to ignore EBUSY errors, which prevents the boot process from failing if core filesystems like /proc, /sys, and /dev/pts are already mounted. A review comment suggests that this logic should also be applied to other mount calls within the same file, specifically in chroot_luks and sev_get_luks_passphrase, to ensure consistent behavior and avoid boot failures in certain environments.
dorindabassey
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to use init.krun while booting from an initramfs.