Merged
Conversation
The shim manager must be exported in order to build a nerdbox shim from outside the main namespace. Signed-off-by: Derek McGowan <derek@mcg.dev>
There was a problem hiding this comment.
Pull request overview
Exports the nerdbox shim manager as a public package so external consumers can build customized shim binaries outside the main repository namespace.
Changes:
- Exported shim manager constructor as
pkg/shim/manager.New(...)and updated the shim binary to use it. - Added OS-specific shim manager implementations (Unix vs Windows) plus mount-namespace handling helpers.
- Added unit tests covering
New,Info, andreadSpec.
Reviewed changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/shim/manager/manager.go | Exposes the shim manager via New and contains shared metadata/spec parsing. |
| pkg/shim/manager/manager_unix.go | Unix shim start/stop implementation, socket setup, and optional user+mount namespace cloning. |
| pkg/shim/manager/manager_windows.go | Windows shim start/stop implementation using named pipes. |
| pkg/shim/manager/mount_linux.go | Linux implementation of mount-namespace cloning and AppArmor userns restriction checks. |
| pkg/shim/manager/mount_other.go | Non-Linux stub implementation of cloneMntNs. |
| pkg/shim/manager/manager_test.go | Tests for exported constructor and shared helper behavior. |
| cmd/containerd-shim-nerdbox-v1/main.go | Switches shim binary to import and use the exported manager package/API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
austinvazquez
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shim manager must be exported in order to build a nerdbox shim from outside the main namespace.
Nerdbox is designed to utilize the plugin system the same way as containerd, allowing customization of the main program or rebuilding of the main for testing outside the main repo.