MSI: Add support for signing of installers #1224
MSI: Add support for signing of installers #1224lrandersson wants to merge 1 commit intoconda:briefcase-integrationfrom
Conversation
conda-bot
added
the
cla-signed
| certificate_file=certificate_file, | ||
| ) | ||
|
|
||
| def _get_signing_params(self): |
There was a problem hiding this comment.
About the changes in this file to simplify review: The new code is based on existing patterns, _get_signing_params() extracts the same environment variables already used in get_signing_command(), and sign() builds the same command structure but as a list for direct execution. The create_signing_tool() function is essentially the same logic that was already in winexe.py, just moved to reduce duplicated code, but reuses existing logic to enable MSI signing.
| CONSTRUCTOR_SIGNING_CERTIFICATE=str(cert_path), | ||
| CONSTRUCTOR_PFX_CERTIFICATE_PASSWORD=cert_pwd, | ||
| ): | ||
| _verify_windows_signature(installer) |
There was a problem hiding this comment.
I added this because I thought it was odd that this test was even passing before signing of installers was supported for MSI Installers. This example was already running for EXE and MSI installers before this PR, and passed for MSI due to lack of actual verification during the testing.
lrandersson
force-pushed
the
briefcase-integration
branch
from
6173fcf to
c9cb1bd
Compare
2 participants
Description
Adds code signing support for MSI installers built via Briefcase, reusing the existing EXE signing infrastructure.
sign()method toWindowsSignToolandAzureSignToolfor direct file signing (post-build)create_signing_tool()factory to reduce duplicationwindows_signing_tool/signing_certificateconfig as EXEtest_example_signingChecklist - did you ...
newsdirectory (using the template) for the next release's release notes?