MSI: Enable protected base#1220
Open
lrandersson wants to merge 4 commits intoconda:briefcase-integrationfrom
Open
MSI: Enable protected base#1220lrandersson wants to merge 4 commits intoconda:briefcase-integrationfrom
lrandersson wants to merge 4 commits intoconda:briefcase-integrationfrom
Conversation
conda-bot
added
the
cla-signed
lrandersson
commented
Apr 23, 2026
| with open(input_path / "construct.yaml") as f: | ||
| config = yaml.load(f) | ||
|
|
||
| # Since the above yaml.load does not rely on jinja rendering, |
Contributor
Author
There was a problem hiding this comment.
After analyzing the code and enabling the test we could see that it should work "out of the box" ever since the support for extra_envs was added. Since preconda.py:write_files handles the necessary logic for protected base.
lrandersson
force-pushed
the
briefcase-integration
branch
from
6173fcf to
c9cb1bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?