Open
Conversation
Contributor
yordis
commented
Apr 14, 2026
yordis
commented
- Make EventStore behavior visible to consumers that need first-party telemetry instead of relying on adapters around it.
- Align lazy stream observability with the actual batch reads that reach PostgreSQL.
- Keep the telemetry namespace consistent with the EventStore application identity.
yordis
force-pushed
the
yordis/feat-add-telemetry
branch
6 times, most recently
from
6c3b2ea to
2f808d4
Compare
yordis
force-pushed
the
yordis/feat-add-telemetry
branch
from
2f808d4 to
777c0ad
Compare
yordis
commented
Apr 14, 2026
| assert {:error, error} = | ||
| Appender.append(conn, 1, recorded_events, schema: schema, timeout: 0) | ||
|
|
||
| assert match?(%DBConnection.ConnectionError{}, error) or error == :query_canceled |
Contributor
Author
There was a problem hiding this comment.
there is an flaky test 😭
yordis
force-pushed
the
yordis/feat-add-telemetry
branch
from
777c0ad to
698bac3
Compare
yordis
force-pushed
the
yordis/feat-add-telemetry
branch
5 times, most recently
from
82e7376 to
5266518
Compare
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
yordis/feat-add-telemetry
branch
from
5266518 to
3ea659c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.