Skip to content

chore: resolve io_other_error and uninlined_format_args warnings for rust 1.88.0#88

Merged
lorisleiva merged 5 commits intocodama-idl:mainfrom
yihau:adapt-rust-1.88
Feb 25, 2026
Merged

chore: resolve io_other_error and uninlined_format_args warnings for rust 1.88.0#88
lorisleiva merged 5 commits intocodama-idl:mainfrom
yihau:adapt-rust-1.88

Conversation

@yihau
Copy link
Copy Markdown
Contributor

@yihau yihau commented Feb 24, 2026

Problem

when I bumped the rust version to 1.88 in a downstream repo, the generated client failed clippy due to these two issues:

  1. https://rust-lang.github.io/rust-clippy/rust-1.88.0/index.html#io_other_error
  2. https://rust-lang.github.io/rust-clippy/rust-1.88.0/index.html#uninlined_format_args

Summary of Changes

for (1), it's quite straightforward: e930afa

for (2), it's a bit subtle. the lint become allow from 1.90.0 (https://rust-lang.github.io/rust-clippy/rust-1.90.0/index.html#uninlined_format_args). I'm not sure if we still wanna adapt it, but I'd prefer doing so: ec7013a

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 24, 2026

🦋 Changeset detected

Latest commit: 90a6dd8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@codama/renderers-rust Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yihau yihau changed the title chore: get lint compatible with Rust 1.88 chore: resolve io_other_error and uninlined_format_args warnings for rust 1.88.0 Feb 24, 2026
Copy link
Copy Markdown
Member

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the fix!

@lorisleiva
Copy link
Copy Markdown
Member

lorisleiva commented Feb 25, 2026

@yihau I think the issue is that the test re-generate the e2e code and ensures the working directory is clean to make sure the test are running on the latest version of the code generation. If you run the tests locally and then commit these changes, you should be good.

EDIT: nvm CI is green now ☺️

@yihau
Copy link
Copy Markdown
Contributor Author

yihau commented Feb 25, 2026

yeah, it's green! thank you for the tips!

@lorisleiva lorisleiva merged commit 6477636 into codama-idl:main Feb 25, 2026
4 checks passed
@yihau yihau deleted the adapt-rust-1.88 branch February 25, 2026 12:08
@github-actions github-actions bot mentioned this pull request Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants