chore: resolve io_other_error and uninlined_format_args warnings for rust 1.88.0#88
Merged
lorisleiva merged 5 commits intocodama-idl:mainfrom Feb 25, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 90a6dd8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
@yihau I think the issue is that the test re-generate the e2e code and ensures the working directory is clean to make sure the test are running on the latest version of the code generation. If you run the tests locally and then commit these changes, you should be good. EDIT: nvm CI is green now |
Contributor
Author
|
yeah, it's green! thank you for the tips! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
when I bumped the rust version to 1.88 in a downstream repo, the generated client failed clippy due to these two issues:
Summary of Changes
for (1), it's quite straightforward: e930afa
for (2), it's a bit subtle. the lint become
allowfrom 1.90.0 (https://rust-lang.github.io/rust-clippy/rust-1.90.0/index.html#uninlined_format_args). I'm not sure if we still wanna adapt it, but I'd prefer doing so: ec7013a