Be a bit more aggresive when cleaning up runners#660
Merged
gabriel-samfira merged 1 commit intocloudbase:mainfrom Mar 7, 2026
Merged
Conversation
In agent mode, we update the DB entity regularly with heartbeats. This gives us a clue that the instance is still up in the IaaS and we can access it via the agent if we need to, but it also means that we can no longer rely on UpdatedAt to know if a runner is still being installed. Instead, we obey the pool/scaleset runner bootstrap timeout. If the runner is not present in the forge after the timeout, we consider it failed and remove it. The agent will be updated to check for more offline statuses. GARM will also be updated to do additional checks for agent enabled runners and cross check those runners against the forge to see if they are still registered. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In agent mode, we update the DB entity regularly with heartbeats. This gives us a clue that the instance is still up in the IaaS and we can access it via the agent if we need to, but it also means that we can no longer rely on UpdatedAt to know if a runner is still being installed.
Instead, we obey the pool/scaleset runner bootstrap timeout. If the runner is not present in the forge after the timeout, we consider it failed and remove it.
The agent will be updated to check for more offline statuses.
GARM will also be updated to do additional checks for agent enabled runners and cross check those runners against the forge to see if they are still registered.