fix(keynote-2): split demo and bench CLI parsing#4703
Open
joshua-spacetime wants to merge 3 commits intomasterfrom
Open
fix(keynote-2): split demo and bench CLI parsing#4703joshua-spacetime wants to merge 3 commits intomasterfrom
joshua-spacetime wants to merge 3 commits intomasterfrom
Conversation
9da39a6 to
ae5adff
Compare
ae5adff to
11b109a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This cleans up the
keynote-2benchmark CLI and fixes thebenchpath that was broken afterdemoandbenchstarted sharing a single parser.demoandbenchnow parse their own command grammars instead of sharing one import-time parser. This avoidsbenchinheritingdemo-style validation and breaking ontest-1 --connectors .... in addition,benchalso uses the samecac-builder asdemonow, and I've deleted the unusedrunner_1.ts.API and ABI breaking changes
None
Expected complexity level and risk
3
Testing
Manually tested the following from
templates/keynote-2:pnpm bench test-1 --seconds 10 --concurrency 50 --alpha 1.5 --connectors spacetimedbpnpm demo --seconds 1 --concurrency 5 --alpha 1.5 --systems spacetimedb --skip-prep --no-animationdeno run --sloppy-imports -A src/demo.ts --helpdeno run --sloppy-imports -A src/cli.ts --helpdeno run --sloppy-imports -A src/cli.ts test-1 --seconds 10 --concurrency 50 --alpha 1.5 --connectors spacetimedb