Bugfix: properly activate and deactivate fps fields when necessary#732
Open
Perdu wants to merge 1 commit intoclementgallet:masterfrom
Open
Bugfix: properly activate and deactivate fps fields when necessary#732Perdu wants to merge 1 commit intoclementgallet:masterfrom
Perdu wants to merge 1 commit intoclementgallet:masterfrom
Conversation
movieRecording is not initialized yet and isChecked() does not return an accurate value at that point in the code. As a fix, we activate the fields by default and deactivate them on movie load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
movieRecording is not initialized yet and isChecked() does not return an accurate value at that point in the code.
As a consequence, we can't edit framerate on new record (without switching to playback and then back to recording mode).
As a fix, we activate the fields by default and deactivate them on movie load.
(Fixes my 59c2985 changes)