Replace link to Ikuyo's Unity guide with an actual link to it#724
Open
IntangibleMatter wants to merge 1 commit intoclementgallet:masterfrom
Open
Replace link to Ikuyo's Unity guide with an actual link to it#724IntangibleMatter wants to merge 1 commit intoclementgallet:masterfrom
IntangibleMatter wants to merge 1 commit intoclementgallet:masterfrom
Conversation
There might be something I'm missing but for some reason the existing link points to WSL. Maybe that's useful in the process but I think it'd make more sense to link to the page itself from TASVideos.
Contributor
|
Dupe of #721 |
Author
|
Yes and no. The other one also has a whole bunch of edits for writing which may or may not be desired based on how things should be formatted. Either way, if a PR already exists then I feel like it probably should've been merged, considering that patches to docs don't break anything, and that the link points to an incorrect resource. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There might be something I'm missing but for some reason the existing link points to WSL. Maybe that's useful in the process but I think it'd make more sense to link to the page itself from TASVideos.