Fix annotations menu when loading movie file with --read CLI option#693
Open
Perdu wants to merge 1 commit intoclementgallet:masterfrom
Open
Fix annotations menu when loading movie file with --read CLI option#693Perdu wants to merge 1 commit intoclementgallet:masterfrom
Perdu wants to merge 1 commit intoclementgallet:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When launching libTAS with the
--readoption to load a movie file (also probably with -w), the annotations menu is greyed out and it is not possible to edit them.Analysis
In
MainWindow.cpp,annotateMovieActionis set to false by default, and only set to true inslotMovieEnable(), called when the user clicks on the checkbox. The case where the checkbox is on when libTAS starts (due to using -w or -r) is not taken into account.Solution
Instead of setting
annotateMovieActionto false by default, we evaluate whether a movie is loaded to set its value. For this, I reused the logic used inupdateMovieParams().