Add setting to display Lua text on video encode#670
Open
Perdu wants to merge 2 commits intoclementgallet:masterfrom
Open
Add setting to display Lua text on video encode#670Perdu wants to merge 2 commits intoclementgallet:masterfrom
Perdu wants to merge 2 commits intoclementgallet:masterfrom
Conversation
Perdu
force-pushed
the
restore_osd_lua
branch
from
1f9a42a to
4de8cfd
Compare
Contributor
Author
|
Edit: Fixed the fact that it doesn't check that we are in a video encode to change settings. |
Perdu
force-pushed
the
restore_osd_lua
branch
from
4de8cfd to
26d6428
Compare
Contributor
Author
|
Fix: new setting was not properly saved to config file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 1dd0c90 replaced the various OSD settings with a single OSD > Main Menu setting. As a consequence, if one now wants to encode video with text from Lua script, the procedure is to:
on each encode.
This commit introduces an option to do that with the simplicity of a setting.