Closed
Conversation
InfoTeddy
suggested changes
Jun 14, 2021
jakobrs
force-pushed
the
random-socket-filename
branch
from
30cb8b3 to
a2c95b5
Compare
InfoTeddy
suggested changes
Jun 14, 2021
|
|
||
| /* Remove the socket file and return error */ | ||
| int removeSocket(); | ||
| int removeSocket(const std::string& socket_filename); |
Contributor
There was a problem hiding this comment.
Instead of a const std::string&, an std::string_view could be used instead.
|
|
||
| /* Initiate a socket connection with the game */ | ||
| bool initSocketProgram(void); | ||
| bool initSocketProgram(const std::string& socket_filename); |
jakobrs
force-pushed
the
random-socket-filename
branch
3 times, most recently
from
08b70b5 to
5607e57
Compare
jakobrs
force-pushed
the
random-socket-filename
branch
from
5607e57 to
361ac73
Compare
Contributor
Author
|
Closing in favour of #425. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll probably want to find a way to use something other thantmpnamto generate the name of the socket, because:Usingtmpnamcauses a deprecation warningThere is a possibility of someone else creating a file with the same name as ours by accidentThere is also the fact that it leaves undeleted socket files in
/tmp(but so did it before the patch too, it's just more obvious when the files get a different name each time)