fix: LHS of pointer assignments can only be pointer arithmetic operations#428
Merged
ckirsch merged 1 commit intocksystemsteaching:mainfrom Apr 18, 2026
Merged
fix: LHS of pointer assignments can only be pointer arithmetic operations#428ckirsch merged 1 commit intocksystemsteaching:mainfrom
ckirsch merged 1 commit intocksystemsteaching:mainfrom
Conversation
Member
|
@GGBOIH250 thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
compile_assignmenttheltypeis an expression and can be changed toltype = compile_arithmetic()as we only have pointer arithmetic or identifier dereferencing on the left hand side of assignments in C*. The default implementation from selfie compiles this with only warnings and no errors:Although running this results in a segfault, I find that compiling it successfully is also not ideal. Changing it to
ltype = compile_arithmetic()incompile_assignment, the self compilation doesn't break undermake selfandmake self-selfand it returns syntax error when above code is now tried to compile.