Make editor windows activatable regardless of editor mode#511
Merged
Conversation
Remove the requirement for editor mode to be activated before opening SelectionWindow, CreatorWindow, PatternEditorWindow, GenomeEditorWindow, MultiplierWindow, and inspector-related features. - Remove EditorController::isOn() check from isShown() in 5 window classes - Remove .disabled(!isEditMode()) from all Editor menu items - Remove editor mode guard from EditorController::process() - Clean up unused EditorController includes Co-authored-by: chrxh <73127001+chrxh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update windows to be activatable without editor mode
Make editor windows activatable regardless of editor mode
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SelectionWindow, CreatorWindow, PatternEditorWindow, GenomeEditorWindow, MultiplierWindow, and inspector features were gated behind editor mode activation. They should be independently activatable.
Window visibility
Removed
EditorController::get().isOn()fromisShown()in all five window classes:Menu items
Removed
.disabled(!SimulationInteractionController::get().isEditMode())from all 11 Editor menu items inMainLoopController.cpp. Functional disable conditions (e.g.,!isObjectInspectionPossible()) are preserved.Editor processing
Removed the
if (!_on) { return; }early-exit inEditorController::process()so inspector windows and editor model updates continue regardless of editor mode state.Cleanup
Removed now-unused
#include "EditorController.h"from four window.cppfiles.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.