Open
Conversation
|
d268bbd to
d7a295e
Compare
In Ruby 3.2.0, `configure.ac` already has the lines added by the patch: https://github.com/ruby/ruby/blob/v3_2_0/configure.ac#L369-L374 Also in `thread_pthread.h`: https://github.com/ruby/ruby/blob/v3_2_0/thread_pthread.h#L93-L100 Signed-off-by: Ben Dean <ben.dean@finvi.com>
d7a295e to
fbf2255
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
If I have a project with a ruby version of 3.2.0 or higher, and I build for CentOS/RHEL, I get the following error when it tries to apply
ruby-3.1.6-configure.patch:The project file looks something like this:
This worked for us previously in 052b094. The diff shows that the constraint for this patch was changed from
= 3.1.6to>= 3.1.6, despite the patch not being needed in>= 3.2.0052b094...50c7885#files_bucket
In Ruby 3.2.0,
configure.acalready has the lines added by the patch: https://github.com/ruby/ruby/blob/v3_2_0/configure.ac#L369-L374Also in
thread_pthread.h:https://github.com/ruby/ruby/blob/v3_2_0/thread_pthread.h#L93-L100
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.