Open
Conversation
… parse failure - Replace close(additionCh) with additionClosed atomic.Bool flag to prevent panic when async producers (redirect/crawl/retry/append) write after pool shutdown - Guard addAddition() with ctx.Err() and additionClosed check before send - ParseRawResponse failure no longer marks baseline as invalid or returns early; log at debug level instead - Read Location header from live response (resp.GetHeader) instead of re-parsed bl.Response.Header for reliability - Add ParseRawResponse boundary tests (nil, empty, truncated, binary, etc.) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Replace additionClosed atomic with ctx-based guard in addAddition - Add handlerDone chan to coordinate Handler goroutine lifecycle - Add sendProcess method with select+ctx.Done protection - Protect putToOutput/putToFuzzy/checkCh sends with select+ctx.Done - Rewrite BrutePool.Close/CheckPool.Close with correct shutdown order: Cancel → Release pools → close(processCh) → <-handlerDone - Fix doCrawl orphan wg.Add(1) with defer wg.Done() - Fix analyzeDone inverted condition (replaced with handlerDone chan) - Add ctx.Done check to Run monitor goroutine Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add 19 tests in core/pool/pool_test.go covering: - addAddition: normal, after cancel, wg balance, full buffer, concurrent - sendProcess: normal, after cancel, full buffer, concurrent - putToOutput/putToFuzzy: normal, after cancel, Outwg balance - Handler lifecycle: processCh close exits handler, drains all items - Shutdown sequence: no deadlock, cancel mid-flight - Goroutine leak detection after full shutdown Add .github/workflows/ci.yml: - Runs on PR to master and push to master - Tests on ubuntu-latest and windows-latest - go build, go test -race, go vet Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.