Skip to content

Enable csi-lib metrics#502

Open
7ing wants to merge 1 commit intocert-manager:mainfrom
7ing:metrics
Open

Enable csi-lib metrics#502
7ing wants to merge 1 commit intocert-manager:mainfrom
7ing:metrics

Conversation

@7ing
Copy link

@7ing 7ing commented Oct 22, 2025 •
edited by wallrj-cyberark
Loading

@cert-manager-prow cert-manager-prow bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Oct 22, 2025
@cert-manager-prow
Copy link
Contributor

cert-manager-prow bot commented Oct 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign munnerz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 22, 2025
@cert-manager-prow
Copy link
Contributor

cert-manager-prow bot commented Oct 22, 2025

Hi @7ing. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 22, 2025
@7ing 7ing mentioned this pull request Oct 22, 2025
Merged
@7ing 7ing marked this pull request as draft October 22, 2025 21:43
@cert-manager-prow cert-manager-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2025
@cert-manager-prow cert-manager-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2025
@cert-manager-prow cert-manager-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 10, 2025
@wallrj-cyberark wallrj-cyberark changed the title Draft: demo for csi-lib metrics feature Enable csi-lib metrics Dec 10, 2025
@wallrj-cyberark wallrj-cyberark marked this pull request as ready for review December 10, 2025 12:56
@cert-manager-prow cert-manager-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2025
@wallrj-cyberark wallrj-cyberark mentioned this pull request Dec 10, 2025
Merged
@wallrj-cyberark
Copy link
Member

wallrj-cyberark commented Dec 10, 2025

/ok-to-test

@cert-manager-prow cert-manager-prow bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 10, 2025
@cert-manager-prow cert-manager-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 10, 2025
@cert-manager-prow cert-manager-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2026
@7ing
Enable csi-lib metrics
62d6b5e 
This PR enables csi-lib metrics feature in
cert-manager/csi-lib#73

Signed-off-by: Jing Liu <jingliu@apple.com>
@cert-manager-prow cert-manager-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2026
@cert-manager-prow cert-manager-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2026
@cert-manager-prow
Copy link
Contributor

cert-manager-prow bot commented Jan 30, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

inteon
inteon reviewed Mar 9, 2026
View reviewed changes
cmd/app/app.go

// Setup metrics handler to track metrics for cert-manager CertificateRequests
// Note, it won't be started if the --metrics-bind-address is "0".
certRequestInformerFactory := externalversions.NewSharedInformerFactory(opts.CMClient, certRequestSharedInformerResyncPeriod)
Copy link
Member

@inteon inteon Mar 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we creating a new informer just for metrics? Is this not something we should already have an informer for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inteon inteon inteon left review comments

Assignees

No one assigned

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@7ing @wallrj-cyberark @inteon