Add adaptive Hystrix implementation to support requests with near baseline latency#155
Open
kitanoyoru wants to merge 10 commits intocep21:masterfrom
Open
Add adaptive Hystrix implementation to support requests with near baseline latency#155kitanoyoru wants to merge 10 commits intocep21:masterfrom
kitanoyoru wants to merge 10 commits intocep21:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #57
Hi, @cep21
This contribution adds
closers/hystrix-adaptive: aClosedToOpenimplementation that wraps the standard Hystrix opener and defers opening the circuit when recent failures are mostly timeouts and additive latency headroom (extra) is still belowMaxExtraLatencyHow it works
Headroom is tracked on top of
BaselineLatency. It increases on timeouts and on successes slower than baseline + extra (step sizeIncreaseExtra, capped byMaxExtraLatency). It decreases when successes finish faster thanBaselineLatency(step sizeDecreaseExtra)ShouldOpenfirst checks the inner Hystrix opener (volume + error %). If the inner wants to open, the adaptive layer may still keep the breaker closed when extra is inWhen extra reaches
MaxExtraLatency, that deferral stops: if the inner opener still wants to open,ShouldOpenreturnstrueso the circuit can open after sustained overloadClosed / Openedreset adaptive state (including extra and adaptive rolling counters)Demo
Source code can be found here