Update transferId assignment logic in BridgeTransferLib#314
Open
0xriptide wants to merge 1 commit intoceler-network:mainfrom
Open
Update transferId assignment logic in BridgeTransferLib#3140xriptide wants to merge 1 commit intoceler-network:mainfrom
0xriptide wants to merge 1 commit intoceler-network:mainfrom
Conversation
Refactor withdrawId computation for consistency in transferId assignment by checking the correct wdId instead of request.refId
alireza237237
approved these changes
Nov 9, 2025
alireza237237
approved these changes
Nov 9, 2025
|
Prompt |
alireza237237
approved these changes
Nov 9, 2025
alireza237237
approved these changes
Nov 9, 2025
|
Great catch — this is exactly the issue I reported in #319. The Your fix looks correct. One thing worth verifying: the same pattern exists in Happy to review if that helps move this forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor withdrawId computation for consistency in transferId assignment by checking the correct wdId instead of request.refId