Conversation
| "<b>Maintenance:</b> Correct invalid column types in system tables.", | ||
| "<b>Maintenance:</b> Parquet Reader accepts files with wrong Page Metadata written by DuckDB until 2024.", | ||
| "<b>Maintenance:</b> Reduce log-noise in docker image due to health check queries.", | ||
| "<b>Maintenance:</b> Fix output of <tt>pg_show_all_settings</tt> to improve compatibility with pgAdmin.", |
There was a problem hiding this comment.
Again here and two lines below, when are they maintenance and when are they compatibility improvements?
| "<b>Maintenance:</b> Change <tt>generate_subscripts</tt> function return type to int32.", | ||
| "<b>Maintenance:</b> Fix JSON representation of arrays with lower bounds other than 1.", | ||
| "<b>Maintenance:</b> Fix a bug where the ordinality result column of <tt>unnest(array) WITH ORDINALITY</tt> was not usable in outer operators.", | ||
| "<b>Maintenance:</b> Fix <tt>ALTER TABLE ... ADD COLUMN ... DEFAULT ... </tt> with different column and default value types.", |
There was a problem hiding this comment.
not sure if this could be also a new feature, because before we just didn't do it. We also fixed the behavior but added functionality. what do you think @Lukasdoe?
| "<b>PostgreSQL Compatibility:</b> Implement `pg_backend_pid()`.", | ||
| "<b>PostgreSQL Compatibility:</b> Implement `pg_stat_get_activity()`.", | ||
| "<b>Maintenance:</b> Fix parsing legacy parquet files without nullability statistics and dictionary encoding.", | ||
| "<b>Maintenance:</b> Correct invalid column types in system tables.", |
There was a problem hiding this comment.
for me this does not make any sense?
Does it mean fix system tables by not allowing invalid column types tables or system tables now always return the correct column type or something completely different?
There was a problem hiding this comment.
It was meant to mean: "Columns in system tables used to have incorrect columns (deviating from postgres), now they have the same column types as postgres uses". Having written this, this should be changed to postgres compat instead of maintenance.
There was a problem hiding this comment.
Ah I didn't read correct as a verb but as an adjective. Maybe you could also rephrase it, as the current sentence is not clear.
Maybe something like
| "<b>Maintenance:</b> Correct invalid column types in system tables.", | |
| "<b>PostgreSQL Compatibility:</b> System tables column types match the postgres column types.", |
There was a problem hiding this comment.
Needs to be sorted above then, but I agree, we should use a better wording. How about "Align system table column types with postgres system table column types"?
01e4667 to
a8f92f4
Compare
No description provided.