pdo: Fix lower bound check in access by index#628
Merged
acolomb merged 1 commit intocanopen-python:masterfrom Mar 12, 2026
Merged
pdo: Fix lower bound check in access by index#628acolomb merged 1 commit intocanopen-python:masterfrom
acolomb merged 1 commit intocanopen-python:masterfrom
Conversation
Extend test to cover access via 0x1400 and 0x1600 yielding the same object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extended access patterns by communication parameter record index only work for TPDOs. The lower bound check on the number range excludes anything below 0x1600, thus RPDO communication parameters do not work.
Extend test to cover access via 0x1400 and 0x1600 yielding the same object.