fix(navigation): dropdown min-width and boundary checking (#5758)#5760
Open
YASH-MOHARIR wants to merge 1 commit intocanonical:mainfrom
Open
fix(navigation): dropdown min-width and boundary checking (#5758)#5760YASH-MOHARIR wants to merge 1 commit intocanonical:mainfrom
YASH-MOHARIR wants to merge 1 commit intocanonical:mainfrom
Conversation
…ary checking (canonical#5758) - Move min-width: 100% into the desktop media query where position: absolute is set, ensuring the dropdown is never narrower than its trigger element - Add max-width: -max-width (40em) to prevent dropdowns from becoming excessively wide on large screens - Add .is-right-overflow CSS class for boundary checking support - Add applyBoundaryChecking() JS function that detects when a dropdown would overflow the right edge of the viewport and flips it to right-aligned Resolves canonical#5758
|
YASH-MOHARIR is not a collaborator of the repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5758
Move min-width: 100% into the desktop media query where position: absolute is set, ensuring the dropdown is never narrower than its trigger element
Add max-width: $text-max-width (40em) to prevent dropdowns from becoming excessively wide on large screens
Add .is-right-overflow CSS class for boundary checking support
Add applyBoundaryChecking() JS function that detects when a dropdown would overflow the right edge of the viewport and flips it to right-aligned
How to test