fix: use clean authoritative flag before checking it (#138)#162
Open
AloizioMacedo wants to merge 1 commit intocanonical:3.7from
Open
fix: use clean authoritative flag before checking it (#138)#162AloizioMacedo wants to merge 1 commit intocanonical:3.7from
AloizioMacedo wants to merge 1 commit intocanonical:3.7from
Conversation
The main issue was that the validation was being done before any
treatment of the inputs, so `self.data.get("authoritative")` was
returning the string that was used in the CLI command (or the API).
Specifically, for example, setting `authoritative=false` resulted in the
code thinking that there was a violation.
Funnily enough, setting `authoritative` to an empty string would let
things pass through, even though authoritative at the end (in the model)
would be True due to its default value there.
Resolves [LP:2147570](https://bugs.launchpad.net/maas/+bug/2147570)
(cherry picked from commit db29503)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main issue was that the validation was being done before any treatment of the inputs, so
self.data.get("authoritative")was returning the string that was used in the CLI command (or the API).Specifically, for example, setting
authoritative=falseresulted in the code thinking that there was a violation.Funnily enough, setting
authoritativeto an empty string would let things pass through, even though authoritative at the end (in the model) would be True due to its default value there.Resolves LP:2147570
(cherry picked from commit db29503)