Fix/s3 output files#1401
Merged
lbeckman314 merged 3 commits intofix/serviceaccount-deletionfrom Apr 29, 2026
Merged
Conversation
…anup Set the worker Job as the owner of all namespaced task resources (ConfigMap, ServiceAccount, Role, RoleBinding, PVC) so Kubernetes garbage-collects them automatically when the Job is deleted. - CreateJob now returns the created Job so callers can read its UID - All Create* functions accept an optional *metav1.OwnerReference - createResources in backend.go creates the Job first, builds the owner ref, and threads it through subsequent resource creation - External (user-managed) SAs via _WORKER_SA tag receive no owner ref since they outlive individual tasks - PVs remain explicitly managed (cluster-scoped resources cannot be owned by a namespaced Job) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Assisted-by: Claude Code:claude [Claude Code]
Signed-off-by: Liam Beckman <lbeckman314@gmail.com>
lbeckman314
changed the base branch from
develop
to
fix/serviceaccount-deletion
Signed-off-by: Liam Beckman <lbeckman314@gmail.com>
lbeckman314
merged commit a7fc01a
into
fix/serviceaccount-deletion
5 of 7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This is a messy PR that's more of a short-term fix for GenericS3 uploads + downloads in K8s while Funnel's default working directory behavior is revisited/updated.