Merged
Conversation
🦋 Changeset detectedLatest commit: 28cbdf4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
thymikee
approved these changes
Jan 16, 2025
Member
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
Any measurable improvements?
Member
Author
measurable? maybe |
jbroma
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Looking over the RN codebase I've found that
ReactNativePrivateInitializeCorereexportsInitializeCore. Inside commit history we can find attempts at making this module a noop but ultimately it was always reverted because of issues at metro.We're not using metro and this isn't an issue with webpack/rspack so no reason why not to try it, especially since this allows for inlining entrypoints for faster startup (before webpack bailed out of this optimization because
InitializeCorewas used in other places)Test plan