feat: use RNC CLI explicitly when bundling the project#869
Merged
Conversation
🦋 Changeset detectedLatest commit: c22906b The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Member
Author
|
canary: https://www.npmjs.com/package/@callstack/repack/v/5.0.0-canary-20250115185948 needs bumping Rspack version manually, will be done inside separate PR |
thymikee
reviewed
Jan 16, 2025
Member
Author
thymikee
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--config-cmdto satisfybundle.jsscript from RN coreCLI_PATHpointing to RNC CLI explicitlyinit for Android now configurescliFileand points to RNC CLI explicitlybuild.gradlefor projects using RN < 0.71bundleinstead ofwebpack-bundlecommandsmodifyAndroidphase of init altogetherPartial solution to #866
Test plan