Skip to content

feat: use RNC CLI explicitly when bundling the project#869

Merged
jbroma merged 12 commits intomainfrom
fix/rnc-cli-release-build
Jan 17, 2025
Merged

feat: use RNC CLI explicitly when bundling the project#869
jbroma merged 12 commits intomainfrom
fix/rnc-cli-release-build

Conversation

@jbroma
Copy link
Member

@jbroma jbroma commented Jan 15, 2025

Summary

  • - added noop --config-cmd to satisfy bundle.js script from RN core
  • - init now replaces the whole shellScript for "Bundle React Native code and images"
  • - init for iOS now exports CLI_PATH pointing to RNC CLI explicitly
  • - init for Android now configures cliFile and points to RNC CLI explicitly
  • - dropped unofficial support for modifying build.gradle for projects using RN < 0.71
  • - use default bundle instead of webpack-bundle commands
  • - removed modifyAndroid phase of init altogether

Partial solution to #866

Test plan

  • - init works locally
  • - project created with canary release builds for release

@changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2025

🦋 Changeset detected

Latest commit: c22906b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@callstack/repack Major
@callstack/repack-init Major
@callstack/repack-plugin-reanimated Major
@callstack/repack-dev-server Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 10:00am

@jbroma
Copy link
Member Author

jbroma commented Jan 15, 2025

canary: https://www.npmjs.com/package/@callstack/repack/v/5.0.0-canary-20250115185948

needs bumping Rspack version manually, will be done inside separate PR

@jbroma
Copy link
Member Author

jbroma commented Jan 17, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants