Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
🦋 Changeset detectedLatest commit: 106a242 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If the library config is not set to
script, MF2 will not handle 2nd level remotes correctly (as in remotes of remotes). This can be currently observed in the super app showcase where it fails to loadAccountScreeninside of any of the MiniApps.Setting library type to
scriptresults inpreloadAssetsflow being trigger, so to counter this I've added a noop handler insidegeneratePreloadAssetshook. This is not needed anyways since when this method is called the assets (chunks of the remote) are already loaded into the container variable in the global scope. Setting this to a noop avoids a flow which is tailored for the browser environment (withdocumentobject present)This should most likely be fixed in MF2 core itself but the solution to a similar issue boils down to using
scriptas a workaround for now.Test plan