perf: do 'lazy' comparison in 'checkIfCacheDataOutdated'#855
Merged
jbroma merged 2 commits intocallstack:mainfrom Jan 9, 2025
Merged
perf: do 'lazy' comparison in 'checkIfCacheDataOutdated'#855jbroma merged 2 commits intocallstack:mainfrom
jbroma merged 2 commits intocallstack:mainfrom
Conversation
Simplifies comparison with cached data. Also does not 'precompute' it before doing the comparison, so expression terminates on first difference.
🦋 Changeset detectedLatest commit: 35aa7ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
jbroma
reviewed
Jan 8, 2025
Member
jbroma
left a comment
jbroma
left a comment
There was a problem hiding this comment.
subtle but an improvement nonetheless, thanks!
please add changeset to this PR so we can merge this
Contributor
Author
|
Changeset added! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies comparison with cached data. Also does not 'precompute' it before doing the comparison, so expression terminates on first difference.
Summary
Not sure if it is a real problem as the code might be called infrequently. I was just bugged by the eager version.
Test plan