Skip to content

Patches for cookie-reflection and JSON-with-wrong-content-type #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bebiksior merged 4 commits into from
Jun 29, 2025
Merged

Patches for cookie-reflection and JSON-with-wrong-content-type #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8d6f884
change dedupe key for cookie reflection to per path rather than per url
meme-lord Jun 29, 2025
5852f93
reduced FPs from json with wrong content type workflow
meme-lord Jun 29, 2025
cb6ada9
Merge branch 'main' into patches
bebiksior Jun 29, 2025
8edce5d
fix validation errs
bebiksior Jun 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/workflows/src/cookie-reflection/javascript.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export async function run({ request, response }, sdk) {
description: `The response from ${request.getUrl()} contains the value "${cookie_val}" which is also the value of the cookie "${cookie_name}"`,
request: request,
reporter: "CookieValueReflectedInResponse",
dedupeKey: `cookie_reflect_${request.getUrl()}_${cookie_name}_${cookie_val}`,
dedupeKey: `cookie_reflect_${request.getHost()}${request.getPath()()}_${cookie_name}_${cookie_val}`,
});
}
}
Expand Down
18 changes: 10 additions & 8 deletions packages/workflows/src/json-with-wrong-content-type/javascript.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,16 @@ export async function run({ request, response }, sdk) {
if (body.startsWith("{") || body.startsWith("[")) {
// Regex to ignore application/json application/manifest+json
if (!contentTypeHeader[0].match(/^application\/(\w*\+)?json/)) {
const description = `The content of response from ${request.getHost()}${request.getPath()} is probably JSON but the content type is not application/json`;
await sdk.findings.create({
title: "JSON Response Without JSON Content-Type",
description: description,
request: request,
reporter: "JSON Response Without JSON Content-Type",
dedupeKey: description,
});
if (!contentTypeHeader[0].match(/^text\/(javascript|css)/)) {
let description = `The content of response from ${request.getHost()}${request.getPath()} is probably JSON but the content type is not application/json`;
await sdk.findings.create({
title: "JSON Response Without JSON Content-Type",
description: description,
request: request,
reporter: "JSON Response Without JSON Content-Type",
dedupeKey: description,
});
}
}
}
}
Expand Down