Fix GraphQL request detection on response click#13
Conversation
|
@f8thl3ss dropping the cache |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
📝 WalkthroughWalkthroughAdded a validation task to the build configuration that runs multiple checks sequentially. Fixed a bug in GraphQL view mode where response content was incorrectly treated as request content by introducing a filter to distinguish HTTP responses from raw editor text. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/frontend/src/views/GraphQLViewMode.vue`:
- Around line 82-85: Replace the unreliable content-based isResponseContent
check with an editor-type check: call window.getActiveEditor() and use
instanceof (or a type guard) to detect if the active editor is an
HTTPResponseEditor vs HTTPRequestEditor, and return true only for response
editors; update any call sites that rely on isResponseContent to use this new
logic so Pretty/body-only formatted responses are correctly identified (refer to
isResponseContent, window.getActiveEditor(), HTTPResponseEditor and
HTTPRequestEditor to locate the change).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fe9d682e-7730-4b46-9c5b-48a692464c4b
📒 Files selected for processing (2)
.mise/config.tomlpackages/frontend/src/views/GraphQLViewMode.vue
This Fixes #12
Summary by CodeRabbit
Release Notes