[feat][cp] Allow transferring a vector to a given memory pool#489
Open
Weixin-Xu wants to merge 3 commits intobytedance:mainfrom
Open
[feat][cp] Allow transferring a vector to a given memory pool#489Weixin-Xu wants to merge 3 commits intobytedance:mainfrom
Weixin-Xu wants to merge 3 commits intobytedance:mainfrom
Conversation
|
|
Weixin-Xu
force-pushed
the
transferOrCopy
branch
from
bda9827 to
11734aa
Compare
Summary: This diff adds an API `BaseVector::transferOrCopyTo(MemoryPool* pool)` to allow transferring the ownership of a vector to a target memory pool. If a buffer in this vector cannot be transferred (e.g., BufferView), it is copied to the target pool. After the call, the vector is entirely owned by the new pool such that the original pool can be destructed even if this vector is not released yet. (Note that this API transfers a buffer to the target pool even if it's multiply referenced.) from facebookincubator/velox#13814
…buffers are copied Summary: FlatVector::transferOrCopyTo() and ConstantVector::transferOrCopyTo() may copy the string buffers to new ones. However, there was a bug that they didn't udpate the StringViews in the vectors afterwards. StringViews must be updated if a string buffer is replaced by its copy, because StringViews contain pointers to addresses inside the string buffers. This diff updates StringViews in FlatVector::transferOrCopyTo() and ConstantVector::transferOrCopyTo() when a copy of a string buffer occurs. It also updated the unit test to cover these situations. In addition, this diff adds documentation of the BaseVector::transferOrCopyTo() API. It also removes FlatMapVector::transferOrCopyTo() since it's not covered in the unit test yet. from facebookincubator/velox#15489
Weixin-Xu
force-pushed
the
transferOrCopy
branch
from
11734aa to
0f72cce
Compare
Weixin-Xu
force-pushed
the
transferOrCopy
branch
from
0f72cce to
3dd4289
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds an API
BaseVector::transferOrCopyTo(MemoryPool* pool)to allow transferring the ownership of a vector to a target memory pool. If a buffer in this vector cannot be transferred (e.g., BufferView), it is copied to the target pool. After the call, the vector is entirely owned by the new pool such that the original pool can be destructed even if this vector is not released yet. (Note that this API transfers a buffer to the target pool even if it's multiply referenced.)from facebookincubator/velox#13814
What problem does this PR solve?
Issue Number: close #xxx
Type of Change
Description
Describe your changes in detail.
For complex logic, explain the "Why" and "How".
Performance Impact
No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
Positive Impact: I have run benchmarks.
Click to view Benchmark Results
Negative Impact: Explained below (e.g., trade-off for correctness).
Release Note
Please describe the changes in this PR
Release Note:
Checklist (For Author)
Breaking Changes
No
Yes (Description: ...)
Click to view Breaking Changes