Skip to content

WIP: [feature] Allow parallel execution of SparkShuffleReader#481

Open
markjin1990 wants to merge 1 commit intobytedance:mainfrom
markjin1990:parallel-shuffle-reader-new
Open

WIP: [feature] Allow parallel execution of SparkShuffleReader#481
markjin1990 wants to merge 1 commit intobytedance:mainfrom
markjin1990:parallel-shuffle-reader-new

Conversation

@markjin1990
Copy link
Copy Markdown
Collaborator

@markjin1990 markjin1990 commented Apr 3, 2026

What problem does this PR solve?

Allow SparkShuffleReader to run in parallel (multi-threads/drivers) mode.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🚀 Performance improvement (optimization)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🔨 Refactoring (no logic changes)
  • 🔧 Build/CI or Infrastructure changes
  • 📝 Documentation only

Description

  • Previously, SparkShuffleReader is strictly forbidden to run in parallel mode determined by LocalPlanner.cpp. This PR lift this ban and allow SparkShuffleReader to run in parallel mode.
  • Similar to TableScan, SparkShuffleReader operators from different drivers in the same pipeline will share the same shuffle reader client. Although, shuffle read is essentially a sequential read. This PR unblocks the parallel execution in the rest of the pipeline.

Performance Impact

  • No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).

  • Positive Impact: I have run benchmarks.

    Click to view Benchmark Results
    Paste your google-benchmark or TPC-H results here.
    Before: 10.5s
    After:   8.2s  (+20%)
    
  • Negative Impact: Explained below (e.g., trade-off for correctness).

Release Note

Please describe the changes in this PR

Release Note:

Release Note:
- Allow parallel execution of SparkShuffleReader

Checklist (For Author)

  • I have added/updated unit tests (ctest).
  • I have verified the code with local build (Release/Debug).
  • I have run clang-format / linters.
  • (Optional) I have run Sanitizers (ASAN/TSAN) locally for complex C++ changes.
  • No need to test or manual test.

Breaking Changes

  • No

  • Yes (Description: ...)

    Click to view Breaking Changes
    Breaking Changes:
    - Description of the breaking change.
    - Possible solutions or workarounds.
    - Any other relevant information.
    

@markjin1990 markjin1990 force-pushed the parallel-shuffle-reader-new branch from c21f252 to 0454534 Compare April 3, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant