Skip to content

[fix][cp] Fix Greek final sigma and rename forSpark parameter to turkishCasing#465

Open
WangGuangxin wants to merge 2 commits intobytedance:mainfrom
WangGuangxin:cp_13993
Open

[fix][cp] Fix Greek final sigma and rename forSpark parameter to turkishCasing#465
WangGuangxin wants to merge 2 commits intobytedance:mainfrom
WangGuangxin:cp_13993

Conversation

@WangGuangxin
Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: close #191

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🚀 Performance improvement (optimization)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🔨 Refactoring (no logic changes)
  • 🔧 Build/CI or Infrastructure changes
  • 📝 Documentation only

Description

Fix Greek final sigma

Performance Impact

  • No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).

  • Positive Impact: I have run benchmarks.

    Click to view Benchmark Results
    Paste your google-benchmark or TPC-H results here.
    Before: 10.5s
    After:   8.2s  (+20%)
    
  • Negative Impact: Explained below (e.g., trade-off for correctness).

Release Note

Checklist (For Author)

  • I have added/updated unit tests (ctest).
  • I have verified the code with local build (Release/Debug).
  • I have run clang-format / linters.
  • (Optional) I have run Sanitizers (ASAN/TSAN) locally for complex C++ changes.
  • No need to test or manual test.

Breaking Changes

  • No

  • Yes (Description: ...)

    Click to view Breaking Changes
    Breaking Changes:
    - Description of the breaking change.
    - Possible solutions or workarounds.
    - Any other relevant information.
    

…ishCasing

This PR ports two changes from Velox:
1. Rename forSpark parameter to turkishCasing
2. Fix Greek final sigma handling

Original author: Rui Mo <rui@apache.org>
@WangGuangxin WangGuangxin force-pushed the cp_13993 branch 2 times, most recently from d7d21a6 to c957ef7 Compare April 2, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants