build: support compiling with clang 19#458
Open
ZacBlanco wants to merge 6 commits intobytedance:mainfrom
Open
Conversation
17 tasks
Collaborator
NicolasDenoyelle
left a comment
There was a problem hiding this comment.
Hi Zack, I have a couple minor comments.
That looks great overall and a welcome improvement.
I am not well versed in the tests you changed so I would probably put another pair of eyes on it if we have someone who knows that code. I didn't see anything shocking there.
e9391d1 to
eef41c6
Compare
NicolasDenoyelle
approved these changes
Apr 8, 2026
Collaborator
NicolasDenoyelle
left a comment
There was a problem hiding this comment.
LGTM on the latest changes.
eef41c6 to
c16b61d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Brings our project's compatibility with later compilers up to more modern standards. Clang 19 was released in Septemer of 2024.
Type of Change
Description
Updates project to bring compatibility with clang 19. This is important for a number of reasons
Specific changes are outlined here:
.c**files that are in the compilation DB to prevent header include errors. The line filters for headers are should still be propagated to users as long as the headers are used in a modified compilation unit.Performance Impact
Release Note
Please describe the changes in this PR
Release Note:
Checklist (For Author)
Breaking Changes