[fix][cp] Read unannotated array#455
Draft
guhaiyan0221 wants to merge 3 commits intobytedance:mainfrom
Draft
Conversation
Weixin-Xu
reviewed
Apr 15, 2026
guhaiyan0221
force-pushed
the
fix_cp_unannotated_array
branch
from
fb4b7d5 to
73810c5
Compare
Summary: When the element type is scalar type, a check in `convertType` requires the requested type must not be array. However, an unannotated array in Parquet is a repeated field that is not explicitly marked as a LIST logical type. To enable reading of unannotated arrays, this PR verifies the compatibility of their element types. Follow-up for facebookincubator/velox#13620. Corresponding PR: facebookincubator/velox#13864
guhaiyan0221
force-pushed
the
fix_cp_unannotated_array
branch
from
73810c5 to
dc8a22d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #191
Type of Change
Description
Summary:
When the element type is scalar type, a check in
convertTyperequires the requested type must not be array. However, an unannotated array in Parquet is a repeated field that is not explicitly marked as a LIST logical type. To enable reading of unannotated arrays, this PR verifies the compatibility of their element types.Follow-up for facebookincubator/velox#13620.
Corresponding PR: facebookincubator/velox#13864
Performance Impact
No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
Positive Impact: I have run benchmarks.
Click to view Benchmark Results
Negative Impact: Explained below (e.g., trade-off for correctness).
Release Note
Please describe the changes in this PR
Release Note:
Checklist (For Author)
Breaking Changes
No
Yes (Description: ...)
Click to view Breaking Changes