[feat][cp] feat: Add JSON SerDe code for member field LocationHandle::targetFile…#445
Open
WangGuangxin wants to merge 1 commit intobytedance:mainfrom
Open
[feat][cp] feat: Add JSON SerDe code for member field LocationHandle::targetFile…#445WangGuangxin wants to merge 1 commit intobytedance:mainfrom
WangGuangxin wants to merge 1 commit intobytedance:mainfrom
Conversation
…Name_ (#12431) Summary: JSON SerDe code for the field LocationHandle::targetFileName_ is missing. The patch adds it. Related to facebookincubator/velox#10903. Pull Request resolved: facebookincubator/velox#12431 Reviewed By: xiaoxmeng Differential Revision: D70260553 Pulled By: kevinwilfong fbshipit-source-id: 9021ec572e693e284db150de08f24cc077e725c5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #191
Type of Change
Description
JSON SerDe code for the field LocationHandle::targetFileName_ is missing. The patch adds it.
Performance Impact
No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
Positive Impact: I have run benchmarks.
Click to view Benchmark Results
Negative Impact: Explained below (e.g., trade-off for correctness).
Release Note
Checklist (For Author)
Breaking Changes
No
Yes (Description: ...)
Click to view Breaking Changes